kz930 commented on code in PR #8364: URL: https://github.com/apache/texera/pull/8364#discussion_r4255210414
########## workflow-compiling-service/src/test/scala/org/apache/texera/amber/translator/verify/ConfigCoverageSpec.scala: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.translator.verify + +import org.apache.texera.amber.operator.LogicalOp +import org.apache.texera.amber.operator.source.SourceOperatorDescriptor +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.matchers.should.Matchers + +/** + * Holds the floor under what the harness can run. + * + * Every operator carrying standalone code is classified runnable or flagged, and + * a flag is how an operator stops being checked at all. For most that is a state + * someone is working through. For the ones below it would be a regression: they + * are the plainest operators the harness has, they take the shared table as it + * is, and nothing about them is hard to run. An operator arriving here means + * something upstream of the disposition broke rather than that this operator + * became difficult. + */ +class ConfigCoverageSpec extends AnyFlatSpec with Matchers { + + private val mustRun = Set( + "IntersectOpDesc", + "DifferenceOpDesc", + "SymmetricDifferenceOpDesc", + "HashJoinOpDesc", + "SpecializedFilterOpDesc", + "SortOpDesc", + "LimitOpDesc" + ) + + "the harness" should "keep runnable every operator it must be able to run" in { + val flagged = OperatorBehaviorSpec + .discoverStandaloneOperators() Review Comment: Fixed in 41564e7c3. The guard now fails when a must-run operator is missing from discovery, before it checks the disposition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
