tanishqgandhi1908 opened a new pull request, #8973:
URL: https://github.com/apache/texera/pull/8973

   ### What changes were proposed in this PR?
   
   The computing-unit prepull DaemonSet hardcoded imagePullPolicy: Always, so 
on clusters that load images into the nodes (kind, minikube, air-gapped) 
setting texeraImages.pullPolicy to IfNotPresent or Never had no effect on it. 
Its init container still tried to pull from the registry and failed.
   
   It now reads {{ .Values.texeraImages.pullPolicy }}, like the Jupyter prepull 
DaemonSet and every other template that pulls a Texera image. 
texeraImages.pullPolicy defaults to Always, so default installs render exactly 
as before.
   
   Rendered with helm template, before:
   ```
   pullPolicy=Always        | CU prepuller: Always | Jupyter prepuller: Always
   pullPolicy=IfNotPresent  | CU prepuller: Always | Jupyter prepuller: 
IfNotPresent
   pullPolicy=Never         | CU prepuller: Always | Jupyter prepuller: Never
   ```
   After:
   ```
   pullPolicy=Always        | CU prepuller: Always       | Jupyter prepuller: 
Always
   pullPolicy=IfNotPresent  | CU prepuller: IfNotPresent | Jupyter prepuller: 
IfNotPresent
   pullPolicy=Never         | CU prepuller: Never        | Jupyter prepuller: 
Never
   ```
   
   ### Any related issues, documentation, discussions?
   Closes #8972
   
   ### How was this PR tested?
   
   Rendered the DaemonSet with helm template under each texeraImages.pullPolicy 
value, before and after (output above), and with the default values, which 
still give Always. bin/k8s/tests/test_helm_values.sh passes.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to