tanishqgandhi1908 commented on code in PR #8932:
URL: https://github.com/apache/texera/pull/8932#discussion_r4264305464
##########
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.ts:
##########
@@ -195,6 +197,7 @@ export class UserDatasetFileRendererComponent implements
OnInit, OnChanges, OnDe
}
reloadFileContent() {
+ this.fileLoad?.unsubscribe();
Review Comment:
Thanks, good catch. Fixed with following approach - each load now gets an
id, and the readXlsxFile, Papa.parse and readFileAsText callbacks only write
their result if their load is still the current one. Added two tests (CSV and
text) that fail without the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
