dzueck commented on code in PR #8971:
URL: https://github.com/apache/texera/pull/8971#discussion_r4274390456
##########
bin/k8s/templates/base/workflow-computing-unit-pool/workflow-computing-unit-master-prepull-daemonset.yaml:
##########
@@ -48,7 +52,7 @@ spec:
resources:
limits:
cpu: 1m
- memory: 8Mi
+ memory: 256Mi
Review Comment:
It worked fine for me when using normal runtime, but when I tested with my
previous PR #8572 which added VM runtime support it failed to create the pod
due to a lack of memory. This is likely because the VM runtime uses more memory
since it has its own kernel. It seems that adding the sidecar from this PR plus
the VM just put it over the edge. The exact value of 256Mi was not carefully
considered, but I did find in testing for the previous PR that the VM runtime
can add around 200Mb per pod which would line up well here. It is not clear to
me why this was not encountered without Linkerd other than the addition of the
sidecar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
