mengw15 commented on code in PR #8997: URL: https://github.com/apache/texera/pull/8997#discussion_r4285553606
########## LICENSE: ########## @@ -275,6 +278,18 @@ build: Source: https://github.com/yarnpkg/berry License: BSD 2-Clause License (licenses-3rd-party-code/yarn.txt) +BSD 3-Clause License +-------------------------------------- + +This product includes the Project Jupyter logo, drawn into a diagram: + - frontend/src/assets/notebook_migration_tool/tool_popup_diagram.png + Copyright (c) 2014, Project Jupyter + Source: https://github.com/jupyter/design + License: BSD 3-Clause License (licenses/LICENSE-BSD-3-Clause.txt) Review Comment: The upstream LICENSE is the stock BSD 3-Clause text (clause 3 even keeps the `{organization}` placeholder), so its only project-specific part is the copyright line, which the entry carries. ########## LICENSE: ########## @@ -243,8 +243,11 @@ This product bundles the ScalaPB options definition: Source: https://github.com/scalapb/ScalaPB License: Apache License 2.0 (this LICENSE file) -This product includes an icon from Google's Material Symbols: +This product includes icons from Google's Material Symbols: - frontend/src/app/common/icon/model-icon.ts ("hub") + - the "psychology", "smart_toy" and "snippet_folder" icons drawn into + frontend/src/assets/notebook_migration_tool/tool_popup_diagram.png, + python_file_diagram.png and python_folder_diagram.png Review Comment: The entry already says these icons are drawn into the diagram PNGs, so I'll keep it as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
