mengw15 opened a new pull request, #9007:
URL: https://github.com/apache/texera/pull/9007

   ### What changes were proposed in this PR?
   
   Removes the Flarum-backed discussion forum (#2201), as proposed in #9005 and 
#9006. It is off by default, no deployment config runs Flarum, and it has had 
no feature work since 2024. It also ships `bin/forum/flarum.sql`, a dump of a 
development Flarum database under an ASF header.
   
   **11 files deleted, 22 edited, 1 added (+52 / −1788).**
   
   | Area | What went |
   | --- | --- |
   | Frontend | the forum page and `FlarumService`, the `discussion` route, the 
sidebar Forum tab, the dashboard's forum login, the `flarum_remember` cookie 
cleanup on logout, the admin toggle, and the `forum/api/users` JWT exclusion |
   | Config | `gui.tabs.forum_enabled` / `GUI_TABS_FORUM_ENABLED` |
   | Database | `sql/updates/52.sql` deletes the `forum_enabled` row 
config-service seeded into `site_settings`, as `45.sql` did for 
`projects_enabled` |
   | `bin/` | `bin/forum/`, `bin/config.php`, `bin/.htaccess`, their README 
rows, and the `.htaccess` entry in `.licenserc.yaml` |
   
   The dashboard ran the forum login on every sign-in, even with the tab off, 
so this also drops a `forum/api/token` request per sign-in. Comments in 
`JwtAuth`, `OrcidAuthResource` and `AuthResourceSpec` that referred to 
`flarum.service.ts` are reworded.
   
   ### Any related issues, documentation, discussions?
   
   Closes #9005. Discussion: #9006.
   
   ### How was this PR tested?
   
   Removed the forum specs and the forum cases in the dashboard, admin-settings 
and user-icon specs; the dashboard's sidebar link count drops from 15 to 14. 
Locally, the full frontend suite, the config-service specs, 
`DefaultsConfigSpec` and the amber auth resource specs pass, and `52.sql` 
deletes the row on a database seeded with it and is a no-op when rerun.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-5-5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to