CaroFernando commented on issue #8984: URL: https://github.com/apache/texera/issues/8984#issuecomment-6246250030
Status update on the audit. I went through all 236 image and media files tracked in the repository, using the commit that wrote each file's current content, embedded metadata, the description and comments of the PR that added it, and a visual check. Results are recorded in a `PROVENANCE.yaml` manifest at the repository root, one entry per file with its origin (`project-made` / `third-party` / `unknown`), source, licence and the evidence. I kept the format close to what #8985 proposes so its check can consume it. Manifest: https://github.com/CaroFernando/texera/blob/feat/image-provenance/PROVENANCE.yaml (PR to follow) **Summary** | Origin | Files | Notes | |---|---|---| | project-made | 31 | Texera logos, UI screenshots and tutorial GIFs, the UDF icons redrawn in #5686, and the sample media / comment icon described as original in #5568, #8804, #8987 | | third-party | 15 | 8 already in `LICENSE` (SVGRepo, Apple, ORCID, Material Symbols / Jupyter diagrams); 7 need action, below | | unknown | 190 | 13 of these are the vendor logos handled by #8999, leaving **177** | **Third-party files that need action** - `SankeyDiagram.png`: **Adobe Stock** asset 873461140, per its embedded metadata. Must be replaced. - `DumbbellPlot.png`: **Freepik** icon, named as the source in #2149. Must be replaced. - `TypeCasting.png`: Noun Project icon 2103686, named in #929. Noun Project icons are usually CC BY 3.0 (Category A with attribution), but the author and licence still need confirming; replacing it may be simpler. - `ArrowSource.png`, `AsterixDBSource.png`, `HdfsFileScan.png`: Apache Arrow / AsterixDB / Hadoop logos. Need `LICENSE` and `frontend/LICENSE-binary` entries. - `frontend/src/favicon.ico`: the Angular CLI default favicon from 2018. It is not shipped (`angular.json` only copies `src/assets`), so I propose deleting it. **The 177 unknowns** They trace back to 77 commits, and two of them account for almost half: - 51 icons from #2641 (sklearn operators). @aglinxinyuan, do you remember where these came from? One answer would settle a large part of the list. - 34 icons first added in 2017 to `textdb-angular-gui/thirdparty/images/`. The folder name says they are external, so I plan to replace them rather than search. - The remaining ~92 come from ~75 operator PRs, 1–2 icons each. **Plan** Following what was agreed in #8800: 1. Before the RCs: replace `SankeyDiagram.png` and `DumbbellPlot.png`, add the missing `LICENSE` entries, remove the unused favicon, and merge the manifest. 2. Because the remaining audit will take more than a few days, use the `DISCLAIMER-WIP` route agreed in #8800, pointing at the `unknown` entries of the manifest as the known issue. As @pjfanning noted, this does not cover anything known to be non-Category-A, which is why step 1 comes first. 3. Continue the audit after the RCs: reverse image search for the scattered icons, and replace anything that can't be proven, following the typographic style from #8999 or with Ant Design icons (already a dependency). **Open question** @mengw15's question in #8800 about whether **AI-generated icons** are acceptable replacements is still unanswered. It matters for step 3. Until there is an answer, I'll stick to typographic icons rendered with a CC0 font, as #8999 does, and icons from Category A libraries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
