aglinxinyuan opened a new issue, #9067:
URL: https://github.com/apache/texera/issues/9067

   ### Task Summary
   
   `UserDatasetVersionCreatorComponent` 
(`frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/`)
 carries four pieces of dead code:
   
   - `isCreateButtonDisabled`: never written, so it is always `false`; its only 
read is the `[disabled]="isCreateButtonDisabled || isCreating"` operand.
   - The injected `formBuilder: FormBuilder`, which nothing reads.
   - The `.file-uploader` style: no element in this template has had the class 
since the uploader moved out.
   - The `.toggle-item .help-text` style: no element in this template has ever 
had that class.
   
   **Introduced by** #2413 (2024-02-27, "Introduce Dataset GUI"): 
`isCreateButtonDisabled`, `formBuilder` and `.file-uploader`. #3663 
(2025-08-17, "feat: adding option to allow owner to disallow downloading 
datasets"): `.help-text`.
   
   **Usage removed by:**
   
   - `.file-uploader`: #3296 (2025-03-11, "Add FileService as a standalone 
microservice, LakeFS+S3 as dataset storage") removed the `<div 
class="file-uploader">` wrapper.
   - The other three: never used.
   
   This is a pure deletion with no behaviour change: `[disabled]="false || 
isCreating"` is `[disabled]="isCreating"`.
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to