aglinxinyuan opened a new pull request, #9070: URL: https://github.com/apache/texera/pull/9070
### What changes were proposed in this PR? Removes dead code from `UserDatasetVersionCreatorComponent`. **+3/−19 lines.** There is no behaviour change. - **`isCreateButtonDisabled`:** nothing ever writes it, so it is always `false`. The create button's `[disabled]="isCreateButtonDisabled || isCreating"` becomes `[disabled]="isCreating"`, which evaluates identically. - **The `formBuilder` injection:** nothing reads it. `FormBuilder` is provided in root, so dropping the parameter (and its import) changes nothing. - **`.file-uploader` and `.toggle-item .help-text`:** the component uses emulated encapsulation and no element in its template has either class. The `files-uploader` child renders its own `.file-uploader`, which this stylesheet can't reach. ### History | | | | --- | --- | | **Introduced by** | #2413 (2024-02-27), "Introduce Dataset GUI": `isCreateButtonDisabled`, `formBuilder` and `.file-uploader`. #3663 (2025-08-17), "feat: adding option to allow owner to disallow downloading datasets": `.help-text` | | **Usage removed by** | #3296 (2025-03-11), "Add FileService as a standalone microservice, LakeFS+S3 as dataset storage", removed the `<div class="file-uploader">` wrapper. `isCreateButtonDisabled`, `formBuilder` and `.help-text` were **never used** | `isCreateButtonDisabled` and `formBuilder` have been unused for the two and a half years since they were added. ### Any related issues, documentation, discussions? Closes #9067 ### How was this PR tested? No new tests. The component spec's create-button cases still cover the `[disabled]` binding through `isCreating`. From `frontend/`: - `npx ng test --watch=false --include='**/user-dataset-version-creator.component.spec.ts' --include='**/user-dataset.component.spec.ts' --include='**/result-exportation.component.spec.ts'`: 3 files, 105 tests, all pass. The last two specs cover the component's two modal hosts. - `yarn format:ci`: clean. - `npx ng build`: success. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
