bobbai00 commented on code in PR #6009:
URL: https://github.com/apache/texera/pull/6009#discussion_r4333209460
##########
frontend/src/app/workspace/component/agent/agent-interaction/agent-interaction.component.ts:
##########
@@ -176,112 +185,43 @@ export class AgentInteractionComponent implements
OnInit, OnChanges {
return !!this.selectedAgentId && !!this.feedbackMessage.trim();
}
- /**
- * Check if sample records represent a visualization (has
__is_visualization__ flag).
- */
public isVisualization(): boolean {
- if (!this.sampleRecords || this.sampleRecords.length === 0) return false;
- return this.sampleRecords[0]["__is_visualization__"] === true;
+ return this.resultMode?.type === "SetSnapshotMode";
Review Comment:
This PR keeps the backend unchanged, so it still uses the legacy contract,
which only returns table or visualization results. SetDeltaMode can't reach
these checks, so we're keeping them as they are. I want to revisit this when
the backend result model, i.e. `SyncExecutionResource` is redesigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
