aglinxinyuan opened a new pull request, #9087: URL: https://github.com/apache/texera/pull/9087
### What changes were proposed in this PR? Removes three unused members from `ReportGenerationService`: the private `isAIAssistantEnabled` field, the injected `http: HttpClient`, and the `AI_ASSISTANT_API_BASE_URL` constant. The now-unused `HttpClient` and `AppSettings` imports go too. **+2/−11 lines.** There is no behaviour change. Nothing reads any of them, and nothing builds the service by hand; Angular DI creates it, so dropping a constructor parameter is safe. The spec drops its empty `HttpClient` stub, whose comment already noted that `http` is "injected by the service and never used". ### History | | | | --- | --- | | **Introduced by** | #2816 (2024-10-15), "Enhancing Report Generation by Adding Story-teller Ai based on Ai flag", which added all three to this service. Its HTTP calls live in `AiAnalystService` | | **Usage removed by** | **never used** | They have been unused for the two years since they were added. ### Any related issues, documentation, discussions? Closes #9084 ### How was this PR tested? No new tests. From `frontend/`: - `npx ng test --watch=false --include='**/report-generation.service.spec.ts' --include='**/menu.component.spec.ts'`: 2 files, 169 tests, all pass. These are the only specs that provide or inject the service. - `npx tsc --noEmit -p src/tsconfig.app.json` and `-p src/tsconfig.spec.json`: clean. - `yarn format:ci`: clean. - `npx ng build`: success. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
