aglinxinyuan opened a new pull request, #9086:
URL: https://github.com/apache/texera/pull/9086

   ### What changes were proposed in this PR?
   
   Removes `AdminUserService` clients for admin endpoints that no longer exist, 
or never did. **+1/−35 lines.** There is no behaviour change.
   
   - **`getUploadedFiles` / `USER_CREATED_FILES`** 
(`/admin/user/uploaded_files`) and **`getAccessFiles` / `USER_ACCESS_FILES`** 
(`/admin/user/access_files`): no production caller, and the backend endpoints 
are gone, so any call would 404.
   - **`USER_UPLOADED_DATASE_SIZE`** (`/admin/user/dataset_size`) and 
**`USER_UPLOADED_DATASET_COUNT`** (`/admin/user/uploaded_dataset`): no 
references at all. Neither path was ever served under `/admin/user`; the 
dataset-size endpoint lived under `/quota`.
   - The `File` type import, which only the removed methods used. `File` itself 
stays; `UserQuotaComponent` still imports it.
   
   The spec drops the two cases and two error-propagation rows that only 
exercised the removed methods.
   
   ### History
   
   | | |
   | --- | --- |
   | **Introduced by** | #2194 (2023-10-29), "User quota dashboard frontend": 
the two file clients. #2615 (2024-05-08), "Add Dataset-related statistics to 
Quota Dashboard": the two dataset constants |
   | **Usage removed by** | #2781 (2024-08-20), "Remove File-Related 
Components", which removed the file clients' callers and their backend 
endpoints. #2680 (2024-07-23), "Adding quota statisitc visualization", which 
removed the dataset constants' readers |
   
   They have been unused for over two years.
   
   ### Any related issues, documentation, discussions?
   
   Closes #9083
   
   ### How was this PR tested?
   
   No new tests.
   
   From `frontend/`:
   
   - `npx ng test --watch=false --include='**/admin-user.service.spec.ts' 
--include='**/admin-user.component.spec.ts' 
--include='**/user-quota.component.spec.ts'`: 3 files, 97 tests, all pass. The 
last two specs cover the service's consumers.
   - `npx tsc --noEmit -p src/tsconfig.app.json` and `-p 
src/tsconfig.spec.json`: clean.
   - `yarn format:ci`: clean.
   - `npx ng build`: success.
   
   To re-check:
   
   ```
   git grep -n -w -E 
'getUploadedFiles|getAccessFiles|uploaded_files|access_files|dataset_size|uploaded_dataset'
   # no hits
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5.5)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to