aglinxinyuan opened a new issue, #9110:
URL: https://github.com/apache/texera/issues/9110

   ### Task Summary
   `BreakpointConditionInputComponent` 
(`frontend/src/app/workspace/component/code-editor-dialog/breakpoint-condition-input/`)
 has two public positioning methods, `left()` and `top()`, that nothing in 
production calls. The popup is positioned by `ngOnChanges`, which computes 
`topPosition`/`leftPosition` for the template's `[ngStyle]` binding; the 
template, its one host (`code-debugger`) and every `ViewChild` reference never 
call the two methods. Only spec cases use them.
   
   **Introduced by** #2953 (2024-10-25, "Add Udon breakpoint UI - 
breakpoint-related operations"), in the same commit as the `[ngStyle]` 
positioning that is actually used.
   
   **Usage removed by:** never used.
   
   Removing the two methods and the spec cases that only exercised them is a 
pure deletion with no behaviour change.
   
   ### Task Type
   - [x] Refactor / Cleanup
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to