Yicong-Huang commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4365181914
##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
name: rc-artifacts
path: |
${{ steps.vars.outputs.src_tarball }}
- ${{ steps.vars.outputs.src_tarball }}.asc
${{ steps.vars.outputs.src_tarball }}.sha512
${{ steps.vars.outputs.compose_tarball }}
- ${{ steps.vars.outputs.compose_tarball }}.asc
${{ steps.vars.outputs.compose_tarball }}.sha512
vote-email.txt
retention-days: 7
- upload-rc:
- runs-on: ubuntu-latest
- needs: create-rc
-
- steps:
- - name: Download RC artifacts
- uses: actions/download-artifact@v8
- with:
- name: rc-artifacts
-
- - name: Verify downloaded artifacts
+ - name: Generate release summary
Review Comment:
**Advisory:**
This step replaces the `upload-rc` job, which was the only job with `needs:
create-rc`. The seven `outputs:` that `create-rc` still declares (lines 56-63)
are now read by nothing, and the workflow is `workflow_dispatch` only, so no
caller can read them either. Steps in the same job read `steps.vars.outputs.*`
directly. Please delete the `outputs:` block so the next editor does not go
looking for a consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
