JackieTien97 commented on code in PR #119:
URL: https://github.com/apache/tsfile/pull/119#discussion_r1642064473
##########
java/tsfile/src/main/java/org/apache/tsfile/read/reader/page/AlignedPageReader.java:
##########
@@ -67,7 +69,7 @@ public AlignedPageReader(
ByteBuffer timePageData,
Decoder timeDecoder,
List<PageHeader> valuePageHeaderList,
- List<ByteBuffer> valuePageDataList,
+ List<LazyLoadPageData> valuePageDataList,
Review Comment:
add UT for this new constructor
##########
java/tsfile/src/main/java/org/apache/tsfile/read/reader/page/AlignedPageReader.java:
##########
@@ -92,6 +94,38 @@ public AlignedPageReader(
this.valueCount = valuePageReaderList.size();
}
+ @TestOnly
Review Comment:
not only test use it, some class like `CompactionAlignedChunkReader` and
`ReadChunkAlignedSeriesCompactionExecutor` will still use this constructor.
##########
java/tsfile/src/main/java/org/apache/tsfile/read/reader/page/AlignedPageReader.java:
##########
@@ -92,6 +94,38 @@ public AlignedPageReader(
this.valueCount = valuePageReaderList.size();
}
+ @TestOnly
+ public AlignedPageReader(
+ PageHeader timePageHeader,
+ ByteBuffer timePageData,
+ Decoder timeDecoder,
+ List<PageHeader> valuePageHeaderList,
+ List<ByteBuffer> valuePageDataList,
+ List<TSDataType> valueDataTypeList,
+ List<Decoder> valueDecoderList,
+ Filter globalTimeFilter,
+ boolean isLazyLoaded) {
Review Comment:
what's this parameter for? we shouldn't change the interface method signature
##########
java/tsfile/src/test/java/org/apache/tsfile/read/reader/AlignedPageReaderPushDownTest.java:
##########
@@ -137,7 +137,8 @@ private AlignedPageReader generateAlignedPageReader(
valuePageDataList,
valueDataTypeList,
valueDecoderList,
- globalTimeFilter);
+ globalTimeFilter,
+ false);
Review Comment:
```suggestion
```
##########
java/tsfile/pom.xml:
##########
@@ -92,6 +92,12 @@
<artifactId>gson</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.jetbrains</groupId>
+ <artifactId>annotations</artifactId>
+ <version>24.1.0</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
```suggestion
```
##########
java/tsfile/src/test/java/org/apache/tsfile/read/reader/AlignedPageReaderPushDownTest.java:
##########
@@ -163,7 +164,8 @@ private AlignedPageReader
generateSingleColumnAlignedPageReader(
valuePageDataList,
valueDataTypeList,
valueDecoderList,
- globalTimeFilter);
+ globalTimeFilter,
+ false);
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
