761417898 opened a new pull request, #124:
URL: https://github.com/apache/tsfile/pull/124
The ZigZag encoder is inconsistent with the Java Edition.
In C++ Edition, explicit type casting is required for unsigned right shifts.
Here are unit tests:
```
TEST_F(ZigzagEncoderTest, EncodeInt32) {
IntZigzagEncoder encoder;
common::ByteStream stream(1024, common::MOD_ZIGZAG_OBJ);
int data[] = {1, -1, 12345, -12345, 0, INT32_MAX, INT32_MIN};
for (auto value : data) {
EXPECT_EQ(encoder.encode(value), common::E_OK);
}
encoder.flush(stream);
ASSERT_GT(stream.total_size(), 0);
uint32_t want_len = 21, read_len;
uint8_t real_buf[21] = {};
stream.read_buf(real_buf, want_len, read_len);
EXPECT_EQ(want_len, read_len);
// Generated using Java Edition
uint8_t expected_buf[] = {19, 7, 2, 1, 242, 192, 1, 241, 192, 1, 0, 254,
255, 255, 255, 15, 255, 255, 255, 255, 15};
for (int i = 0; i < 21; i++) {
EXPECT_EQ(real_buf[i], expected_buf[i]);
}
}
TEST_F(ZigzagEncoderTest, EncodeInt64) {
LongZigzagEncoder encoder;
common::ByteStream stream(1024, common::MOD_ZIGZAG_OBJ);
int64_t data[] = {1, -1, 12345, -12345, 0, INT64_MAX, INT64_MIN};
for (auto value : data) {
EXPECT_EQ(encoder.encode(value), common::E_OK);
}
encoder.flush(stream);
ASSERT_GT(stream.total_size(), 0);
uint32_t want_len = 31, read_len;
uint8_t real_buf[31] = {};
stream.read_buf(real_buf, want_len, read_len);
EXPECT_EQ(want_len, read_len);
// Generated using Java Edition
uint8_t expected_buf[] = {29, 7, 2, 1, 242, 192, 1, 241, 192, 1, 0, 254,
255, 255, 255, 255,
255, 255, 255, 255, 1, 255, 255, 255, 255, 255, 255, 255, 255,
255, 1};
for (int i = 0; i < 31; i++) {
EXPECT_EQ(real_buf[i], expected_buf[i]);
}
}
class ZigzagDecoderTest : public ::testing::Test {};
TEST_F(ZigzagDecoderTest, DecodeInt32) {
IntZigzagEncoder encoder;
common::ByteStream stream(1024, common::MOD_ZIGZAG_OBJ);
int32_t data[] = {1, -1, 12345, -12345, 0, INT32_MAX, INT32_MIN};
for (auto value : data) {
EXPECT_EQ(encoder.encode(value), common::E_OK);
}
encoder.flush(stream);
IntZigzagDecoder decoder;
for (int i = 0; i < sizeof(data) / sizeof(int32_t); i++) {
EXPECT_EQ(data[i], decoder.decode(stream));
}
}
TEST_F(ZigzagDecoderTest, DecodeInt64) {
LongZigzagEncoder encoder;
common::ByteStream stream(1024, common::MOD_ZIGZAG_OBJ);
int64_t data[] = {1, -1, 12345, -12345, 0, INT64_MAX, INT64_MIN};
for (auto value : data) {
EXPECT_EQ(encoder.encode(value), common::E_OK);
}
encoder.flush(stream);
LongZigzagDecoder decoder;
for (int i = 0; i < sizeof(data) / sizeof(int64_t); i++) {
EXPECT_EQ(data[i], decoder.decode(stream));
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
