HTHou commented on code in PR #112: URL: https://github.com/apache/tsfile/pull/112#discussion_r1644387116
########## python/setup.py: ########## @@ -0,0 +1,98 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +from setuptools import setup, Extension +from setuptools.command.build_ext import build_ext +from Cython.Build import cythonize +import numpy as np +import platform +import shutil +import os + + +def copy_lib_files(system, source_dir, target_dir, file_ext, version=None): + if version: + lib_file_name = f"libtsfile.{file_ext}.{version}" + else: + lib_file_name = f"libtsfile.{file_ext}" + + source = os.path.join(source_dir, lib_file_name) + target = os.path.join(target_dir, lib_file_name) + shutil.copyfile(source, target) + + if system == "Linux" and version: + link_name = os.path.join(target_dir, f"libtsfile.{file_ext}") + if os.path.exists(link_name): + os.remove(link_name) + os.symlink(lib_file_name, link_name) + +def copy_header(source, target): + shutil.copyfile(source, target) + +class BuildExt(build_ext): + def build_extensions(self): + numpy_include = np.get_include() + for ext in self.extensions: + ext.include_dirs.append(numpy_include) + super().build_extensions() + + +project_dir = os.path.dirname(__file__) +libtsfile_shard_dir = os.path.join(project_dir, "..", "cpp", "build", "Debug", "lib") +libtsfile_dir = os.path.join(project_dir, "tsfile") +include_dir = os.path.join(project_dir, "tsfile") +source_file = os.path.join(project_dir, "tsfile", "tsfile_pywrapper.pyx") + +if platform.system() == "Darwin": + copy_lib_files("Darwin", libtsfile_shard_dir, libtsfile_dir, "dylib") +elif platform.system() == "Linux": + copy_lib_files("Linux", libtsfile_shard_dir, libtsfile_dir, "so", "1.0") +else: + raise Exception("Unsupported platform") + +source_include_dir = os.path.join(project_dir, "..", "cpp", "src", "cwrapper", "TsFile-cwrapper.h") +target_include_dir = os.path.join(project_dir, "tsfile", "TsFile-cwrapper.h") +copy_header(source_include_dir, target_include_dir) + + + +ext_modules_tsfile = [ + Extension( + "tsfile.tsfile_pywrapper", + sources=[source_file], + libraries=["tsfile"], + library_dirs=[libtsfile_dir], + include_dirs=[include_dir, np.get_include()], + runtime_library_dirs=[libtsfile_dir], + extra_compile_args=["-std=c++11"], + language="c++" + ) +] + +setup( + name="tsfile", Review Comment: I remember the ASF requires the name of python package starting with `apache-`. See https://incubator.apache.org/guides/distribution.html#pypi It that true? @chrisdutz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
