RkGrit commented on code in PR #110:
URL: https://github.com/apache/tsfile/pull/110#discussion_r1650288426
##########
cpp/src/writer/tsfile_writer.cc:
##########
@@ -220,8 +220,7 @@ int TsFileWriter::do_check_schema(const std::string
&device_name,
if (UNLIKELY(ms_iter == msm.end())) {
chunk_writers.push_back(NULL);
} else {
- // Here we may check data_type against ms_iter. But in Java
- // libtsfile, no check here.
+ // In Java we will check data_type. But in C++, no check here.
Review Comment:
because checks are performed at the chunk layer and page layer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
