761417898 commented on code in PR #192:
URL: https://github.com/apache/tsfile/pull/192#discussion_r1714843319


##########
cpp/src/writer/tsfile_writer.cc:
##########
@@ -396,6 +552,21 @@ int TsFileWriter::write_column(ChunkWriter *chunk_writer, 
const Tablet &tablet,
         return ret;                                                      \
     } while (false)
 
+#define DO_VALUE_WRITE_TYPED_COLUMN()                                         \
+    do {                                                                      \
+        int ret = E_OK;                                                       \
+        for (int r = 0; r < row_count; r++) {                                 \
+            if (LIKELY(col_bitmap.test(r))) {                                 \
+                ret = value_chunk_writer->write(timestamps[r], col_values[r], \
+                                                false);                       \
+            } else {                                                          \
+                ret = value_chunk_writer->write(timestamps[r], col_values[r], \
+                                                true);                        \
+            }                                                                 \

Review Comment:
   The name has been standardized to `col_notnull_map`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to