HTHou commented on code in PR #304:
URL: https://github.com/apache/tsfile/pull/304#discussion_r1847548075
##########
cpp/test/CMakeLists.txt:
##########
@@ -30,7 +30,8 @@ set(TIMEOUT 30)
foreach(URL ${URL_LIST})
message(STATUS "Trying to download from ${URL}")
- file(DOWNLOAD ${URL} "${CMAKE_BINARY_DIR}/googletest-release-1.12.1.zip"
STATUS DOWNLOAD_STATUS TIMEOUT ${TIMEOUT})
+ file(DOWNLOAD ${
+ URL} "${CMAKE_BINARY_DIR}/googletest-release-1.12.1.zip" STATUS
DOWNLOAD_STATUS TIMEOUT ${TIMEOUT})
Review Comment:
The CI failed caused by this change. Consider reverting it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]