jt2594838 commented on code in PR #364:
URL: https://github.com/apache/tsfile/pull/364#discussion_r1903623277
##########
cpp/test/CMakeLists.txt:
##########
@@ -16,6 +16,8 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
]]
+cmake_minimum_required(VERSION 3.11)
+project(TsFile_CPP_TEST)
include(FetchContent)
set(URL_LIST
Review Comment:
Maybe GTEST_URL_LIST? In case we have more dependencies in the future.
##########
cpp/CMakeLists.txt:
##########
@@ -65,24 +64,18 @@ elseif (CMAKE_BUILD_TYPE STREQUAL "MinSizeRel")
endif()
message("CMAKE DEBUG: CMAKE_CXX_FLAGS=${CMAKE_CXX_FLAGS}")
+
+# All libs will store here, including libtsfile, compress-encoding lib.
Review Comment:
store -> be stored, the same below
##########
cpp/cmake/CopyToDIr.cmake:
##########
@@ -0,0 +1,19 @@
+# CopyToDir.cmake
Review Comment:
License
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
