761417898 commented on code in PR #345:
URL: https://github.com/apache/tsfile/pull/345#discussion_r1919757015
##########
cpp/src/common/tsfile_common.h:
##########
@@ -287,15 +294,17 @@ struct ChunkMeta {
};
struct ChunkGroupMeta {
- // std::string device_name_;
- common::String device_name_;
+ std::shared_ptr<IDeviceID> device_name_;
+ common::String device_name_str_;
Review Comment:
fixed
##########
cpp/src/common/tsfile_common.h:
##########
@@ -287,15 +294,17 @@ struct ChunkMeta {
};
struct ChunkGroupMeta {
- // std::string device_name_;
- common::String device_name_;
+ std::shared_ptr<IDeviceID> device_name_;
+ common::String device_name_str_;
common::SimpleList<ChunkMeta *> chunk_meta_list_;
explicit ChunkGroupMeta(common::PageArena *pa_ptr)
- : device_name_(), chunk_meta_list_(pa_ptr) {}
+ : chunk_meta_list_(pa_ptr) {}
- FORCE_INLINE int init(const std::string &dev_name, common::PageArena &pa) {
- return device_name_.dup_from(dev_name, pa);
+ FORCE_INLINE int init(std::shared_ptr<IDeviceID> device_id,
+ common::PageArena &pa) {
+ device_name_ = device_id;
+ return device_name_str_.dup_from(device_id->get_device_name(), pa);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
