ColinLeeo commented on code in PR #345:
URL: https://github.com/apache/tsfile/pull/345#discussion_r1922738712
##########
cpp/src/writer/tsfile_writer.h:
##########
@@ -61,13 +65,26 @@ class TsFileWriter {
int register_aligned_timeseries(
const std::string &device_id,
const std::vector<MeasurementSchema *> &measurement_schemas);
+ void register_table(const std::shared_ptr<TableSchema> &table_schema);
Review Comment:
I dont think pass a shared pointer to writer is a good idea. The
TableSchema is internal info and shold not pass a sharedPtr directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
