jt2594838 commented on code in PR #386:
URL: https://github.com/apache/tsfile/pull/386#discussion_r1926247505
##########
java/tsfile/src/main/java/org/apache/tsfile/write/writer/tsmiterator/DiskTSMIterator.java:
##########
@@ -78,22 +78,24 @@ public boolean hasNext() {
}
@Override
- public Pair<Path, TimeseriesMetadata> next() {
+ public Pair<Path, TimeseriesMetadata> next() throws IOException {
try {
if (remainsInFile) {
// deserialize from file
- return getTimeSerisMetadataFromFile();
+ return getTimeSeriesMetadataFromFile();
} else {
// get from memory iterator
return super.next();
}
} catch (IOException e) {
- LOG.error("Meets IOException when reading timeseries metadata from
disk", e);
- return null;
+ if (!Thread.currentThread().isInterrupted()) {
+ LOG.error("Meets IOException when reading timeseries metadata from
disk", e);
+ }
+ throw e;
}
Review Comment:
May catch ClosedByInterruptException and ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
