jt2594838 commented on code in PR #435:
URL: https://github.com/apache/tsfile/pull/435#discussion_r1988240923
##########
cpp/CMakeLists.txt:
##########
@@ -52,8 +52,8 @@ endif()
if (NOT CMAKE_BUILD_TYPE)
- set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Choose the type of build."
FORCE)
endif ()
+set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Choose the type of build." FORCE)
Review Comment:
Revert this
##########
cpp/CMakeLists.txt:
##########
@@ -69,7 +69,7 @@ endif ()
message("CMAKE DEBUG: CMAKE_CXX_FLAGS=${CMAKE_CXX_FLAGS}")
# disable asan by default.
-option(ENABLE_ASAN "Enable Address Sanitizer" OFF)
+option(ENABLE_ASAN "Enable Address Sanitizer" ON)
Review Comment:
Revert this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
