Copilot commented on code in PR #473:
URL: https://github.com/apache/tsfile/pull/473#discussion_r2057798939
##########
java/tsfile/src/main/java/org/apache/tsfile/read/common/block/column/BinaryColumn.java:
##########
@@ -146,7 +146,7 @@ public boolean mayHaveNull() {
@Override
public boolean isNull(int position) {
- return valueIsNull != null && valueIsNull[position + arrayOffset];
+ return values[position] == null || valueIsNull != null &&
valueIsNull[position + arrayOffset];
Review Comment:
Verify if the access to the values array should consider the arrayOffset
(i.e., values[position + arrayOffset]) to maintain consistency with the null
check performed on valueIsNull.
```suggestion
return values[position + arrayOffset] == null || valueIsNull != null &&
valueIsNull[position + arrayOffset];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
