jt2594838 commented on code in PR #748:
URL: https://github.com/apache/tsfile/pull/748#discussion_r3015049181
##########
cpp/src/common/tablet.cc:
##########
@@ -150,7 +155,9 @@ void Tablet::destroy() {
case BLOB:
case TEXT:
case STRING:
- common::mem_free(value_matrix_[c].string_data);
+ value_matrix_[c].string_col->destroy();
+ value_matrix_[c].string_col->~StringColumn();
+ common::mem_free(value_matrix_[c].string_col);
Review Comment:
It is a bit weird to call both destroy and destruction.
Why is destory not included in destruction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
