jt2594838 commented on code in PR #772:
URL: https://github.com/apache/tsfile/pull/772#discussion_r3061795014
##########
cpp/src/common/global.cc:
##########
@@ -54,12 +54,15 @@ void init_config_value() {
g_config_value_.int64_encoding_type_ = TS_2DIFF;
g_config_value_.float_encoding_type_ = GORILLA;
g_config_value_.double_encoding_type_ = GORILLA;
+ g_config_value_.string_encoding_type_ = PLAIN;
// Default compression type is LZ4
#ifdef ENABLE_LZ4
g_config_value_.default_compression_type_ = LZ4;
#else
g_config_value_.default_compression_type_ = UNCOMPRESSED;
#endif
+ g_config_value_.parallel_write_enabled_ = true;
+ g_config_value_.write_thread_count_ = 6;
Review Comment:
Is it possible to sense the number of cores?
We may forget to disable parallel-write for end scenarios, and it would be
better to auto-disable parallel-write when there is only one core.
##########
cpp/src/common/global.h:
##########
@@ -163,6 +163,20 @@ FORCE_INLINE uint8_t get_global_compression() {
return static_cast<uint8_t>(g_config_value_.default_compression_type_);
}
+FORCE_INLINE void set_parallel_write_enabled(bool enabled) {
+ g_config_value_.parallel_write_enabled_ = enabled;
+}
+
+FORCE_INLINE bool get_parallel_write_enabled() {
+ return g_config_value_.parallel_write_enabled_;
+}
Review Comment:
&& g_config_value_.write_thread_count_ != 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
