JackieTien97 commented on code in PR #816: URL: https://github.com/apache/tsfile/pull/816#discussion_r3251950524
########## python/tsfile/dataset/dataframe.py: ########## @@ -52,42 +51,45 @@ # multiple shards. _OVERLAP_ROW_CHUNK_SIZE = 256 +MODEL_TABLE = "table" +MODEL_TREE = "tree" Review Comment: `MODEL_TABLE` and `MODEL_TREE` are defined identically in both `reader.py:37-38` and `dataframe.py:54-55`. The dataframe module already imports from reader (`from .reader import ...`). Consider defining these constants once in `reader.py` (or `metadata.py`) and importing them in `dataframe.py` to avoid drift. The test file imports `MODEL_TABLE` from `reader`, so both definitions are actively used — easy to get them out of sync in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
