[ 
http://jira.xwiki.org/jira/browse/XTOOLS-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_18295
 ] 

Vincent Massol commented on XTOOLS-13:
--------------------------------------

Thomas, I've tried to apply your patch but I don't understand it... Could you 
please add comments in the sources to explain what you're doing. Like why 
you're adding some extra dirs to the archive and why you're deleting 
directories. Also you've modifed a method signature but doing so you've broken 
the javadoc for that method. We need to improve XWiki's javadoc so new code 
must at the very least be as good as current code in term of javadoc and even 
better slightly improve it, if we want to get better... :)

Thanks
-Vincent



> Dependencies overlod project pages
> ----------------------------------
>
>                 Key: XTOOLS-13
>                 URL: http://jira.xwiki.org/jira/browse/XTOOLS-13
>             Project: XWiki Platform Tools
>          Issue Type: Bug
>          Components: XAR Plugin
>    Affects Versions: 1.5
>            Reporter: Thomas Mortagne
>         Attachments: 20070914-fix-dependencies-overload-pages.patch
>
>
> When application project is build using maven, pages are moved in 
> /target/classes then dependencies xar uncompressed in /target/classes then 
> xar is made from /target/classes. So in that process dependencies pages 
> overload project pages if there is collisions.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
notifications mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/notifications

Reply via email to