[ 
http://jira.xwiki.org/jira/browse/XE-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marius Dumitru Florea updated XE-130:
-------------------------------------

    Attachment: xe-xmlrpc-tests.diff.130.txt

Vincent,
I followed your suggestion and modified the xmlrpc validity test to fail 
whenever a error/warning message is reported. Here's the patch.

> Fix Velocity warnings
> ---------------------
>
>                 Key: XE-130
>                 URL: http://jira.xwiki.org/jira/browse/XE-130
>             Project: XWiki Enterprise
>          Issue Type: Improvement
>          Components: Other
>    Affects Versions: 1.1
>            Reporter: Vincent Massol
>         Assigned To: Vincent Massol
>            Priority: Minor
>             Fix For: 1.2 M1
>
>         Attachments: xe-wiki.diff.130.txt, xe-xmlrpc-tests.diff.130.txt
>
>
> When running the XMLRPC validity test (the one  that checks for valid XHMTL) 
> we can see there are several warnings raised by Velocity which need to be 
> corrected.
> For example:
> {noformat}
> Validating Blog.Category
> 12:54:19,736 [P1-18] ERROR log.SimpleLog4JLogSystem        - Left side 
> ($velocityCount) of '==' operation has null value. If a reference, it may not 
> be in the context. Operation not possible. Blog.Category [line 50, column 42] 
> 12:54:19,901 [P1-18] ERROR log.SimpleLog4JLogSystem        - Left side 
> ($velocityCount) of '==' operation has null value. If a reference, it may not 
> be in the context. Operation not possible. Blog.Category [line 50, column 42] 
> Validating Blog.CreateBlogPost
> Validating Blog.Macros
> Validating Blog.WebHome
> Validating Blog.WikiLaunch
> Validating Main.AllDocs
> Validating Main.BlogRss
> Validating Main.Dashboard
> Validating Main.EventCalendar
> Validating Main.LuceneSearch
> Validating Main.RecentMembers
> Validating Main.RssFeeds
> Validating Main.SpaceIndex
> Validating Main.Tags
> Validating Main.TagsRss
> Validating Main.WebHome
> Validating Main.WebRss
> Validating Main.WebSearch
> Validating Main.WebSearchRss
> Validating Main.WhatsNew
> Validating Panels.AddClassProperty
> Validating Panels.AddObject
> Validating Panels.Backlinks
> Validating Panels.BlogCategories
> Validating Panels.ClassEditorWelcome
> Validating Panels.ClassSwitcher
> Validating Panels.CreatePanel
> Validating Panels.DocumentInformation
> Validating Panels.EditTranslations
> Validating Panels.GlobalRightsEditorWelcome
> Validating Panels.HomePageUpdate
> Validating Panels.IncludedDocuments
> Validating Panels.Members
> Validating Panels.MyRecentModifications
> Validating Panels.Navigation
> Validating Panels.NewPage
> Validating Panels.ObjectEditorWelcome
> Validating Panels.OrphanedPages
> Validating Panels.PanelClass
> Validating Panels.PanelLayoutUpdate
> 12:59:04,813 [P1-19] ERROR log.SimpleLog4JLogSystem        - Left side 
> ($request.xpage) of '==' operation has null value. If a reference, it may not 
> be in the context. Operation not possible. Panels.PanelLayoutUpdate [line 6, 
> column 26] 
> Validating Panels.PanelSheet
> Validating Panels.PanelTemplate
> 12:59:15,445 [P1-19] WARN  doc.XWikiDocument               - Failed to 
> display field [category] in [view] mode for Object [Panels.PanelTemplate] 
> 12:59:15,536 [P1-19] WARN  doc.XWikiDocument               - Failed to 
> display field [category] in [view] mode for Object [Panels.PanelTemplate] 
> Validating Panels.PanelWizard
> 12:59:20,506 [P1-19] ERROR log.SimpleLog4JLogSystem        - Left side 
> ($first) of '==' operation has null value. If a reference, it may not be in 
> the context. Operation not possible. Panels.PanelWizard [line 6, column 14] 
> 12:59:20,508 [P1-19] ERROR log.SimpleLog4JLogSystem        - Left side 
> ($first) of '==' operation has null value. If a reference, it may not be in 
> the context. Operation not possible. Panels.PanelWizard [line 6, column 14] 
> 12:59:20,510 [P1-19] ERROR log.SimpleLog4JLogSystem        - Left side 
> ($first) of '==' operation has null value. If a reference, it may not be in 
> the context. Operation not possible. Panels.PanelWizard [line 6, column 14] 
> 12:59:20,512 [P1-19] ERROR log.SimpleLog4JLogSystem        - Left side 
> ($first) of '==' operation has null value. If a reference, it may not be in 
> the context. Operation not possible. Panels.PanelWizard [line 6, column 14] 
> 12:59:21,075 [P1-19] ERROR log.SimpleLog4JLogSystem        - Left side 
> ($showLeftPanels) of '==' operation has null value. If a reference, it may 
> not be in the context. Operation not possible. Panels.PanelWizard [line 136, 
> column 23] 
> 12:59:21,075 [P1-19] ERROR log.SimpleLog4JLogSystem        - Left side 
> ($showRightPanels) of '==' operation has null value. If a reference, it may 
> not be in the context. Operation not possible. Panels.PanelWizard [line 139, 
> column 24] 
> Validating Panels.QuickLinks
> Validating Panels.Recently Created
> Validating Panels.Recently Modified
> {noformat}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
notifications mailing list
notifications@xwiki.org
http://lists.xwiki.org/mailman/listinfo/notifications

Reply via email to