Kengo Seki created YETUS-153:
--------------------------------
Summary: asflicense plugin does not work if
asflicense-rat-excludes option is specified
Key: YETUS-153
URL: https://issues.apache.org/jira/browse/YETUS-153
Project: Yetus
Issue Type: Bug
Components: Test Patch
Reporter: Kengo Seki
The following command seems to succeed...
{code}
[sekikn@mobile yetus]$ cat /tmp/rat_excludes
.gitignore
.gitattributes
Gemfile.lock
assets
[sekikn@mobile yetus]$ precommit/test-patch.sh --build-tool=nobuild
--plugins=all YETUS-78 --asflicense-rat-excludes=/tmp/rat_excludes
--asflicense-rat-jar=/tmp/apache-rat-0.11/apache-rat-0.11.jar
/tmp/yetus-388.3525 has been created
(snip)
============================================================================
============================================================================
Determining number of patched ASF License errors
============================================================================
============================================================================
cd /Users/sekikn/yetus
/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home/bin/java -jar
/tmp/apache-rat-0.11/apache-rat-0.11.jar -s /private/tmp/yetus-388.3525/asf.xsl
-E /tmp/rat_excludes -d /Users/sekikn/yetus >
/private/tmp/yetus-388.3525/patch-asflicense.txt 2>&1
Total Elapsed time: 0m 17s
+1 overall
____ _
/ ___| _ _ ___ ___ ___ ___ ___| |
\___ \| | | |/ __/ __/ _ \/ __/ __| |
___) | |_| | (_| (_| __/\__ \__ \_|
|____/ \__,_|\___\___\___||___/___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 07s | precommit patch detected.
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| +1 | shellcheck | 0m 00s | There were no new shellcheck issues.
| +1 | whitespace | 0m 00s | Patch has no whitespace issues.
| +1 | asflicense | 0m 01s | Patch does not generate ASF License
| | | | warnings.
| | | 0m 17s |
{code}
...but asflicense failed silently.
{code}
[sekikn@mobile yetus]$ cat /private/tmp/yetus-388.3525/patch-asflicense.txt
Mon Nov 2 17:19:01 JST 2015
cd /Users/sekikn/yetus
/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home/bin/java -jar
/tmp/apache-rat-0.11/apache-rat-0.11.jar -s /private/tmp/yetus-388.3525/asf.xsl
-E /tmp/rat_excludes -d /Users/sekikn/yetus
usage: java rat.report [options] [DIR|TARBALL]
Options
-A,--addLicense Add the default licence header to any file
with an unknown licence that is not in the
exclusion list. By default new files will
be created with the licence header, to
force the modification of existing files
use the --force option.
-a,--addLicence Add the default licence header to any file
with an unknown licence that is not in the
exclusion list. By default new files will
be created with the licence header, to
force the modification of existing files
use the --force option.
-c,--copyright <arg> The copyright message to use in the
licence headers, usually in the form of
"Copyright 2008 Foo"
-d,--dir Used to indicate source when using
--exclude
-E,--exclude-file <fileName> Excludes files matching regular expression
in <file> Note that --dir is required when
using this parameter.
-e,--exclude <expression> Excludes files matching wildcard
<expression>. Note that --dir is required
when using this parameter. Allows multiple
arguments.
-f,--force Forces any changes in files to be written
directly to the source files (i.e. new
files are not created)
-h,--help Print help for the Rat command line
interface and exit
-s,--stylesheet <arg> XSLT stylesheet to use when creating the
report. Not compatible with -x
-x,--xml Output the report in raw XML format. Not
compatible with -s
NOTE:
Rat is really little more than a grep ATM
Rat is also rather memory hungry ATM
Rat is very basic ATM
Rat highlights possible issues
Rat reports require intepretation
Rat often requires some tuning before it runs well against a project
Rat relies on heuristics: it may miss issues
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
