[ 
https://issues.apache.org/jira/browse/YETUS-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002275#comment-15002275
 ] 

Allen Wittenauer commented on YETUS-23:
---------------------------------------

bq. should we be checking the exit code of filterBugs?

We probably should given how fragile findbugs has shown to be, but it's gonna 
require us to break up that construction since we'd be catching the return code 
of the awk.  I'd rather tackle that a different day as part of a general code 
cleanup; there are lots of places like this where we should do that.

Thanks for the review, I'm going to commit this one!

> findbugs pre-apply check failures gives error as if convertXmlToText 
> invocation fails
> -------------------------------------------------------------------------------------
>
>                 Key: YETUS-23
>                 URL: https://issues.apache.org/jira/browse/YETUS-23
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>             Fix For: YETUS-83
>
>         Attachments: YETUS-23.00.patch, YETUS-23.01.patch
>
>
> We are constantly seeing convertXmlToText errors in the YETUS-83 beta test. 
> Multiple runs of the same patch give different results, so there's clearly a 
> race condition of some sort. My hunch is low memory, but clearly lack data on 
> the how and why's.
> edit: when pre-apply for findbugs fails, it was giving the error text from 
> when convertXmlToText invocation fails rather than properly indicating a 
> problem with the code base.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to