[
https://issues.apache.org/jira/browse/YETUS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008129#comment-15008129
]
Kengo Seki commented on YETUS-123:
----------------------------------
I confirmed that YETUS-76, YETUS-131 and YETUS-148 are fixed. Almost +1, other
than the following questions and minor nits:
* Running test-patch for hadoop fails if specifying --personality and not
specifying --project. Specifying --branch-default is needed to make it succeed.
Is this an expected behaviour, or did I miss something?
* If docker command is executable but docker service is down, docker mode is
not disabled and test-patch fails. Should dockerverify cover such a case?
* In docker_rm_old_containers, stoptime and curtime should be local variables.
* The words "used" in shelldocs are wrongly replaced with $\{SED}.
* Client and server versions are empty in the footer table on my environment
(OSX/Boot2docker), because the output format is as follows:
{code}
[sekikn@mobile yetus]$ docker version
Client:
Version: 1.8.3
API version: 1.20
Go version: go1.4.2
Git commit: f4bf5c7
Built: Mon Oct 12 18:01:15 UTC 2015
OS/Arch: darwin/amd64
Server:
Version: 1.8.3
API version: 1.20
Go version: go1.4.2
Git commit: f4bf5c7
Built: Mon Oct 12 18:01:15 UTC 2015
OS/Arch: linux/amd64
{code}
> Various Docker mode fixes: plug-in issues, local patch file problems,
> availability, & Dockerfile re-usability
> -------------------------------------------------------------------------------------------------------------
>
> Key: YETUS-123
> URL: https://issues.apache.org/jira/browse/YETUS-123
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Affects Versions: 0.1.0
> Reporter: Sean Busbey
> Assignee: Allen Wittenauer
> Priority: Critical
> Fix For: YETUS-83
>
> Attachments: YETUS-123.00.patch, YETUS-123.01.patch,
> YETUS-123.02.patch, YETUS-123.03.patch, YETUS-123.04.patch,
> YETUS-123.05.patch, YETUS-123.06.patch
>
>
> I've made three goes at running in docker mode and all fail in a way that
> suggests the set of plugins isn't making it over to the docker invocation.
> since hadoop is working, I guess there's something that presumes a
> personality will be used?
> builds:
> *
> [13|https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-YETUS-Build/13]
> *
> [14|https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-YETUS-Build/14]
> *
> [28|https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-YETUS-Build/28]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
