[ 
https://issues.apache.org/jira/browse/YETUS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186046#comment-15186046
 ] 

Sean Busbey commented on YETUS-325:
-----------------------------------

{code}
+            if len(jira.get_release_note()) > 0 or \
+               jira.get_incompatible_change() or jira.get_important():
                 reloutputs.write_key_raw(jira.get_project(), "\n---\n\n")
                 reloutputs.write_key_raw(jira.get_project(), line)
-                line = '\n**WARNING: No release note provided for this 
incompatible change.**\n\n'
-                lint_message += "\nWARNING: incompatible change %s lacks 
release notes." % \
-                                (textsanitize(jira.get_id()))
+                if len(jira.get_release_note()) == 0:
+                    line = '\n**WARNING: No release note provided for this 
change.**\n\n'
+                else:
+                    line = '\n%s\n\n' % 
(processrelnote(jira.get_release_note()))
{code}

Isn't this going to result in double warnings since the linter will warn for 
the same thing?

> Refactor releasedocmaker.py lint functionality into separate class
> ------------------------------------------------------------------
>
>                 Key: YETUS-325
>                 URL: https://issues.apache.org/jira/browse/YETUS-325
>             Project: Yetus
>          Issue Type: Sub-task
>    Affects Versions: 0.1.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: YETUS-325.001.patch, YETUS-325.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to