[
https://issues.apache.org/jira/browse/YETUS-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576912#comment-15576912
]
Xiao Chen commented on YETUS-465:
---------------------------------
Thanks [~aw] for explaining this from both yetus and hadoop pov. Now I for sure
can remember findbugs warnings are not to be forgiven. :)
> findbugs should not -1 if base branch has warnings when the patch fixes them
> ----------------------------------------------------------------------------
>
> Key: YETUS-465
> URL: https://issues.apache.org/jira/browse/YETUS-465
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Reporter: Xiao Chen
>
> In HADOOP-13669, the base branch (trunk) has 2 findbugs warnings, and a patch
> fixes them. But pre-commit returns:
> {noformat}
> -1 findbugs 0m 26s hadoop-common-project/hadoop-kms in trunk has 2
> extant Findbugs warnings.
> {noformat}
> IMO this would be better if it says +1 and (had 2 warnings, fixed).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
