[ 
https://issues.apache.org/jira/browse/YETUS-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271088#comment-16271088
 ] 

Sean Busbey commented on YETUS-586:
-----------------------------------

thanks for the contribution [~ajisakaa]! as a nit for the future, I'd rather we 
use long-form arguments when they're around. But I don't think we've been doing 
this with git so I don't htink it ought to hold up this patch.

The man for {{git add -A}} calls out this bit:

{code}
If no <pathspec> is given when -A option is used, all files in the entire 
working tree are updated (old versions of Git used to limit the update to the 
current directory
           and its subdirectories).
{code}

Could you confirm that our minimum stated git version doesn't have this old 
behavior? I don't have an easy way to check at the moment.

> smart-apply-patch --committer misses new directories
> ----------------------------------------------------
>
>                 Key: YETUS-586
>                 URL: https://issues.apache.org/jira/browse/YETUS-586
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.7.0
>            Reporter: Allen Wittenauer
>            Assignee: Akira Ajisaka
>            Priority: Critical
>         Attachments: YETUS-586.000.patch
>
>
> if smart-apply-patch is given a patch that is in raw patch format (e.g., 
> HDFS-11096 #7), it will not add the new directories when run with --committer 
> mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to