[ https://issues.apache.org/jira/browse/YETUS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813696#comment-16813696 ]
Yetus QA commented on YETUS-724: -------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m 29s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 10s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 1s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 7s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 3m 3s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/PreCommit-YETUS-Build/1005/artifact/patchprocess/Dockerfile | | JIRA Issue | YETUS-724 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12965354/YETUS-724.01.patch | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux f24192a22912 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | precommit/src/main/shell/personality/yetus.sh | | git revision | master / bcd6e83 | | Max. process+thread count | 46 (vs. ulimit of 1000) | | modules | C: precommit U: precommit | | Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/1005/console | | versions | git=2.7.4 maven=3.3.9 shellcheck=0.6.0 | | Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > github diff vs. patch > --------------------- > > Key: YETUS-724 > URL: https://issues.apache.org/jira/browse/YETUS-724 > Project: Yetus > Issue Type: New Feature > Components: Precommit > Reporter: Allen Wittenauer > Assignee: Allen Wittenauer > Priority: Major > Fix For: 0.10.0 > > Attachments: YETUS-724.00.patch, YETUS-724.01.patch > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Experience has shown that patch is more accurate diff. However, we could > still try diff. Doing so would enable a lot more scenarios where unsquashed > commits would work. Warn that reported line numbers and binary files may not > be accurate as a result rather than just flat out failing... with the premise > that some output is better than none. -- This message was sent by Atlassian JIRA (v7.6.3#76005)