[
https://issues.apache.org/jira/browse/YETUS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293790#comment-17293790
]
Allen Wittenauer commented on YETUS-1102:
-----------------------------------------
> Even the annotations are working as expected
Doing a quick pass, no, they aren't. If that was the case, cc, javac,
javadoc, test4test, and "can't apply patch" errors would be showing up properly
in the 'Files Changed' output or in the Checks screen. There have been quite a
few Hadoop PRs that aren't showing these annotations. In some cases (like the
latter two) that's missing functionality.
> The comment notifies us that the build is finished. The GitHub status does
> not notify.
Sure it does. Jenkins updates the status in the PR listing with a yellow dot
and a "continuous-integration/jenkins/pr-merge Pending — This commit is being
built " as soon as the PR is kicked off. I'm literally looking at the top of
the PR chain now as running without even having to look at Jenkins.
> The elapsed times are included in the comment. They are important metrics for
> long running job.
The community in general hasn't cared about how long stuff runs in probably a
decade. Besides, if Hadoop actually cared about how long stuff ran, this value
wouldn't be this high:
https://github.com/apache/hadoop/blob/trunk/dev-support/Jenkinsfile#L26 . It
has gone up by 5-6 hours since I last looked a few years ago.
> We can view the history of build summary by just scrolling the screen of the
> PR.
The final history is kept with the PR. The continual running list isn't
particularly useful if commits are getting properly squashed and just adds
noise.
> Add an option to comment to GitHub PR
> -------------------------------------
>
> Key: YETUS-1102
> URL: https://issues.apache.org/jira/browse/YETUS-1102
> Project: Yetus
> Issue Type: Improvement
> Reporter: Akira Ajisaka
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In YETUS-994, the Yetus comments have been replaced with GitHub Statuses.
> However, it is not useful for some Hadoop developers. I want to add an option
> to enable the previous behavior.
> CC: [~ayushsaxena], [[email protected]], and [~ahussein].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
