[
https://issues.apache.org/jira/browse/YETUS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer resolved YETUS-180.
------------------------------------
Resolution: Not A Problem
Most of these are checked appropriately nowadays and it would be better to have
specific issues for specific locations at this point. Closing as Not a Problem.
> Ensure return codes are getting checked
> ---------------------------------------
>
> Key: YETUS-180
> URL: https://issues.apache.org/jira/browse/YETUS-180
> Project: Yetus
> Issue Type: Bug
> Components: Precommit
> Affects Versions: 0.1.0
> Reporter: Sean Busbey
> Priority: Major
>
> we have a few places where we aren't checking return codes, particularly
> during pipes.
> e.g. in findbugs.sh:
> {code}
> + module_findbugs_warnings=$("${FINDBUGS_HOME}/bin/filterBugs" -first \
> + "${PATCH_BRANCH}" \
> + "${warnings_file}.xml" \
> + "${warnings_file}.xml" \
> + | ${AWK} '{print $1}')
> +
> + if [[ ${module_findbugs_warnings} -gt 0 ]] ; then
> + msg="${module} in ${PATCH_BRANCH} has ${module_findbugs_warnings}
> extant Findbugs warnings."
> {code}
> ensure we're checking return code generally and PIPESTATUS specifically.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
