TisonKun commented on a change in pull request #1019: ZOOKEEPER-3464:enfore
checkstyle in the zookeeper-server module and clean the package:admin and client
URL: https://github.com/apache/zookeeper/pull/1019#discussion_r307090332
##########
File path: pom.xml
##########
@@ -582,19 +582,20 @@
<version>${checkstyle.version}</version>
</dependency>
</dependencies>
- <configuration>
- <configLocation>checkstyle.xml</configLocation>
-
<suppressionsLocation>checkstyleSuppressions.xml</suppressionsLocation>
- <encoding>UTF-8</encoding>
- <consoleOutput>true</consoleOutput>
- <failOnViolation>true</failOnViolation>
- <includeResources>false</includeResources>
- <includeTestSourceDirectory>true</includeTestSourceDirectory>
- </configuration>
<executions>
<execution>
<id>checkstyle</id>
<phase>validate</phase>
+ <configuration>
+ <configLocation>checkstyle.xml</configLocation>
Review comment:
@maoling you can take a look at ZOOKEEPER-3465 and #1022 #1023 where I show
you how to enable checkstyle configuration per pkg and why I stand "no need"
for extra suppression configuration.
You can rebase the subtasks enable it on zookeeper-server(i.e., this thread)
on #1022 . Feel free to share you opinion because I did change the checkstyle
configuration choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
