maoling commented on a change in pull request #1098: ZOOKEEPER-3560: Add
response cache to serve get children (2) requests.
URL: https://github.com/apache/zookeeper/pull/1098#discussion_r337419871
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
##########
@@ -307,9 +310,13 @@ public ZooKeeperServer(FileTxnSnapLog txnLogFactory, int
tickTime, int minSessio
listener = new ZooKeeperServerListenerImpl(this);
- readResponseCache = new ResponseCache();
+ readResponseCache = new ResponseCache(Integer.getInteger(
+ GET_DATA_RESPONSE_CACHE_SIZE,
+ ResponseCache.DEFAULT_RESPONSE_CACHE_SIZE));
- getChildrenResponseCache = new ResponseCache();
+ getChildrenResponseCache = new ResponseCache(Integer.getInteger(
+ GET_CHILDREN_RESPONSE_CACHE_SIZE,
+ ResponseCache.DEFAULT_RESPONSE_CACHE_SIZE));
Review comment:
need to print the log of these two parameters to let users know?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
