ztzg commented on a change in pull request #934: ZOOKEEPER-3301:Enforce the
quota limit
URL: https://github.com/apache/zookeeper/pull/934#discussion_r405289545
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/DelQuotaCommand.java
##########
@@ -43,11 +42,14 @@
private CommandLine cl;
public DelQuotaCommand() {
- super("delquota", "[-n|-b] path");
+ super("delquota", "[-n|-b|-N|-B] path");
OptionGroup og1 = new OptionGroup();
- og1.addOption(new Option("b", false, "bytes quota"));
- og1.addOption(new Option("n", false, "num quota"));
+ og1.addOption(new Option("n", false, "num soft quota"));
+ og1.addOption(new Option("b", false, "bytes soft quota"));
+ og1.addOption(new Option("N", false, "num hard quota"));
+ og1.addOption(new Option("B", false, "bytes hard quota"));
Review comment:
I should have been a bit clearer, because unless I missed something, once
one has used the `-b` flag of `setquota`, for example, one can *never, ever
again* use another flag with `setquota`, *even on another node*, unless one
exits and restarts `zkCli.sh`. That seems a bit extreme as a "feature" :)
(But again: you did not introduce that bug; it was there before. I can fix
it in another ticket/PR.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
