ctubbsii commented on a change in pull request #1314: ZOOKEEPER-3791:
Miscellaneous Maven fixes
URL: https://github.com/apache/zookeeper/pull/1314#discussion_r406566942
##########
File path: zookeeper-assembly/src/main/assembly/lib-package.xml
##########
@@ -54,7 +54,7 @@
<includes>
<include>LICENSE</include>
</includes>
- <outputDirectory>/</outputDirectory>
Review comment:
The maven-assembly-plugin tries to interpret the value of this field
relative to the root of the archive being assembled. On Linux, a `/` would
result in the files being placed at the root of the archive. However, according
to the warning from the maven-assembly-plugin, this relative-path resolution
using an absolute path value (one starting with a slash) is not
platform-dependent. Using `.` here achieves the intended goal of placing the
files at the root of the archive, but does not generate the warning from the
plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
