eolivelli commented on a change in pull request #1352:
URL: https://github.com/apache/zookeeper/pull/1352#discussion_r425194698
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
##########
@@ -1135,30 +1137,17 @@ public void submitRequestNow(Request si) {
}
public static int getSnapCount() {
- String sc = System.getProperty(SNAP_COUNT);
- try {
- int snapCount = Integer.parseInt(sc);
-
- // snapCount must be 2 or more. See
org.apache.zookeeper.server.SyncRequestProcessor
- if (snapCount < 2) {
- LOG.warn("SnapCount should be 2 or more. Now, snapCount is
reset to 2");
- snapCount = 2;
- }
- return snapCount;
- } catch (Exception e) {
- return 100000;
+ int snapCount = Integer.getInteger(SNAP_COUNT, DEFAULT_SNAP_COUNT);
Review comment:
What happens in case of a misconfigured value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
