eolivelli commented on a change in pull request #1356:
URL: https://github.com/apache/zookeeper/pull/1356#discussion_r427192704
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java
##########
@@ -1508,20 +1510,25 @@ private synchronized void startZkServer() {
newLeaderProposal.ackSetsToString(),
Long.toHexString(zk.getZxid()));
- /*
- * ZOOKEEPER-1324. the leader sends the new config it must complete
- * to others inside a NEWLEADER message (see LearnerHandler where
- * the NEWLEADER message is constructed), and once it has enough
- * acks we must execute the following code so that it applies the
- * config to itself.
- */
- QuorumVerifier newQV = self.getLastSeenQuorumVerifier();
+ if (QuorumPeerConfig.isReconfigEnabled()) {
+ /*
+ * ZOOKEEPER-1324. the leader sends the new config it must complete
+ * to others inside a NEWLEADER message (see LearnerHandler where
+ * the NEWLEADER message is constructed), and once it has enough
+ * acks we must execute the following code so that it applies the
+ * config to itself.
+ */
+ QuorumVerifier newQV = self.getLastSeenQuorumVerifier();
- Long designatedLeader = getDesignatedLeader(newLeaderProposal,
zk.getZxid());
+ Long designatedLeader = getDesignatedLeader(newLeaderProposal,
zk.getZxid());
- self.processReconfig(newQV, designatedLeader, zk.getZxid(), true);
- if (designatedLeader != self.getId()) {
- allowedToCommit = false;
+ self.processReconfig(newQV, designatedLeader, zk.getZxid(), true);
+ if (designatedLeader != self.getId()) {
+ LOG.warn("This leader is not the designated leader, it will be
initialized with allowedToCommit = false");
+ allowedToCommit = false;
+ }
+ } else {
+ LOG.debug("Reconfig feature is disabled, skip designatedLeader
calculation and reconfig processing.");
Review comment:
LOG.debug -> what about putting it as LOG.info ?
In your new test cases, are you exercising this branch or the "if
QuorumPeerConfig.isReconfigEnabled()" branch ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
