belugabehr commented on a change in pull request #1361:
URL: https://github.com/apache/zookeeper/pull/1361#discussion_r427454605



##########
File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java
##########
@@ -1407,12 +1391,8 @@ public void deserialize(InputArchive ia, String tag) 
throws IOException {
                 } else if (ephemeralType == EphemeralType.TTL) {
                     ttls.add(path);
                 } else if (eowner != 0) {
-                    HashSet<String> list = ephemerals.get(eowner);
-                    if (list == null) {
-                        list = new HashSet<String>();
-                        ephemerals.put(eowner, list);
-                    }
-                    list.add(path);

Review comment:
       This is `synchronized` in `deleteNode` but not here.  Not sure if it 
matters.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to