[GitHub] [zookeeper] hanm commented on a change in pull request #1253: ZOOKEEPER-3722: make logs of ResponseCache more readable

[GitBox]

hanm commented on a change in pull request #1253:
URL: https://github.com/apache/zookeeper/pull/1253#discussion_r431562907



##########
File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
##########
@@ -314,11 +314,11 @@ public ZooKeeperServer(FileTxnSnapLog txnLogFactory, int 
tickTime, int minSessio
 
         readResponseCache = new ResponseCache(Integer.getInteger(
             GET_DATA_RESPONSE_CACHE_SIZE,
-            ResponseCache.DEFAULT_RESPONSE_CACHE_SIZE));
+            ResponseCache.DEFAULT_RESPONSE_CACHE_SIZE), "getData");
 
         getChildrenResponseCache = new ResponseCache(Integer.getInteger(
             GET_CHILDREN_RESPONSE_CACHE_SIZE,
-            ResponseCache.DEFAULT_RESPONSE_CACHE_SIZE));
+            ResponseCache.DEFAULT_RESPONSE_CACHE_SIZE), "getChild");

Review comment:
       let's replace "getChild" with "getChildren" so it's consistent with the 
op code and the cache name `getChildrenResponseCache`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org