ctubbsii commented on pull request #1802: URL: https://github.com/apache/zookeeper/pull/1802#issuecomment-1027142104
> I have excluded the slf4j binding from zookeeper-server, setting it to "test scope". People that use zookeeper-server as "client" library should not import that binding and reloadj4 into their dependency tree. > > but we want it in the binary tarball. The distribution looks like it's being put together using maven-assembly-plugin using `dependencySets`. Marking it as a test dependency means it might not show up as a transitive dependency for that. So, you can fix that by adding it directly as a dependency to the `zookeeper-assembly/pom.xml`. Here is where you can also add exclusions so logj4 1.2 jars don't make it into the assembly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
