arshadmohammad commented on code in PR #1856:
URL: https://github.com/apache/zookeeper/pull/1856#discussion_r846251275
##########
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java:
##########
@@ -1284,10 +1284,11 @@ public void run() {
} catch (Throwable e) {
if (closing) {
// closing so this is expected
- LOG.warn(
- "An exception was thrown while closing send thread
for session 0x{}.",
- Long.toHexString(getSessionId()),
- e);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug(
+ "An exception was thrown while closing send
thread for session 0x{}.",
+ Long.toHexString(getSessionId()), e);
+ }
Review Comment:
It is not a core code flow. So for me it is ok to go either way.
I have put debug enable check to void unnecessary toHexString call.
shall we keep as it is or shall it change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
